Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort-in root classes into packages (architecture) #6853

Merged
merged 7 commits into from
Sep 2, 2020
Merged

Sort-in root classes into packages (architecture) #6853

merged 7 commits into from
Sep 2, 2020

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 2, 2020

Follw-up to #6825.

Siedlerchr
Siedlerchr reviewed Sep 2, 2020
View reviewed changes
src/main/java/org/jabref/logic/citationstyle/CitationStyle.java
@@ -135,7 +134,7 @@ public static CitationStyle getDefault() {
return STYLES;
}

URL url = JabRefMain.class.getResource(STYLES_ROOT + "/acm-siggraph.csl");
URL url = CitationStyle.class.getResource(STYLES_ROOT + "/acm-siggraph.csl");
Objects.requireNonNull(url);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear this change will not work. We explicitly need the root path.

@Siedlerchr
Copy link
Member

Don't forget to update the run configuration in the wiki. We maybe also need to check the build.gradle files for the jpackager arguments

@JabRef JabRef deleted a comment from github-actions bot Sep 2, 2020
@koppor
Copy link
Member Author

koppor commented Sep 2, 2020

  • CSL works
  • Guide was automatically adapted by IntelliJ at the refactoring action 🕺

@koppor koppor merged commit 4aa8378 into master Sep 2, 2020
@koppor koppor deleted the fix-archicture branch September 2, 2020 23:38
Siedlerchr added a commit that referenced this pull request Sep 4, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into writebackupToTemp
1043d9e 
* upstream/master:
  Fix icon issue (#6858)
  No sync of specialfields to keywords as default (#6846)
  Don't show entry editor on startup (#6861)
  Sort-in root classes into packages (#6853)
  Add "Fetchers" to DevDocs
@koppor koppor changed the title Sort-in root classes into packages Sort-in root classes into packages (architecture) Sep 22, 2020
@koppor koppor mentioned this pull request Sep 22, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @Siedlerchr